Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 629113002: Adjusting matcher comments with one-line summaries (Closed)

Created:
6 years, 2 months ago by srawlins
Modified:
6 years, 2 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updating with rnystrom's comment #

Patch Set 3 : Merging master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -44 lines) Patch
M pkg/matcher/lib/src/core_matchers.dart View 3 chunks +10 lines, -6 lines 0 comments Download
M pkg/matcher/lib/src/expect.dart View 4 chunks +10 lines, -5 lines 0 comments Download
M pkg/matcher/lib/src/future_matchers.dart View 1 chunk +8 lines, -5 lines 0 comments Download
M pkg/matcher/lib/src/iterable_matchers.dart View 3 chunks +12 lines, -11 lines 0 comments Download
M pkg/matcher/lib/src/numeric_matchers.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/matcher/lib/src/operator_matchers.dart View 3 chunks +7 lines, -6 lines 0 comments Download
M pkg/matcher/lib/src/string_matchers.dart View 1 2 chunks +21 lines, -9 lines 0 comments Download
M pkg/matcher/lib/src/util.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
srawlins
Hi Bob, let me know if someone else should be the reviewer.
6 years, 2 months ago (2014-10-06 06:34:18 UTC) #2
Bob Nystrom
One suggestion, but LGTM! https://codereview.chromium.org/629113002/diff/1/pkg/matcher/lib/src/string_matchers.dart File pkg/matcher/lib/src/string_matchers.dart (right): https://codereview.chromium.org/629113002/diff/1/pkg/matcher/lib/src/string_matchers.dart#newcode39 pkg/matcher/lib/src/string_matchers.dart:39: /// expect("hello world ", equalsIgnoringCase("hello ...
6 years, 2 months ago (2014-10-06 16:14:28 UTC) #3
srawlins
https://codereview.chromium.org/629113002/diff/1/pkg/matcher/lib/src/string_matchers.dart File pkg/matcher/lib/src/string_matchers.dart (right): https://codereview.chromium.org/629113002/diff/1/pkg/matcher/lib/src/string_matchers.dart#newcode39 pkg/matcher/lib/src/string_matchers.dart:39: /// expect("hello world ", equalsIgnoringCase("hello world")); On 2014/10/06 16:14:28, ...
6 years, 2 months ago (2014-10-06 16:19:35 UTC) #4
srawlins
6 years, 2 months ago (2014-10-06 16:23:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 40938 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698