Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 629043002: Remove from AnalysisServer the 'test_' methods which now has non-test implementations. (Closed)

Created:
6 years, 2 months ago by scheglov
Modified:
6 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove from AnalysisServer the 'test_' methods which now has non-test implementations. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -38 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +0 lines, -27 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 1 chunk +7 lines, -10 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 2 months ago (2014-10-05 17:52:59 UTC) #1
Brian Wilkerson
LGTM
6 years, 2 months ago (2014-10-05 17:56:24 UTC) #2
scheglov
6 years, 2 months ago (2014-10-05 19:57:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40914 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698