Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 628473002: cleanup/organize/improve completion tests (Closed)

Created:
6 years, 2 months ago by danrubel
Modified:
6 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

cleanup/organize/improve completion tests BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40890

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+434 lines, -219 lines) Patch
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 3 chunks +24 lines, -10 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_computer_test.dart View 2 chunks +197 lines, -117 lines 0 comments Download
M pkg/analysis_server/test/services/completion/invocation_computer_test.dart View 5 chunks +113 lines, -43 lines 0 comments Download
M pkg/analysis_server/test/services/completion/local_computer_test.dart View 8 chunks +100 lines, -49 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years, 2 months ago (2014-10-03 03:18:04 UTC) #2
scheglov
LGTM
6 years, 2 months ago (2014-10-03 03:24:58 UTC) #3
danrubel
6 years, 2 months ago (2014-10-03 04:36:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 40890 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698