Create a NullErrorReporter to use when errors don't need to be recorded.

Create a NullErrorReporter to use when errors don't need to be recorded.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40940

[Paul Berry, 2014-10-06 02:58:09]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Paul Berry, 2014-10-06 02:58:09]

To address this review comment:
https://codereview.chromium.org/613303003/diff/20001/editor/tools/plugins/com...

Unfortunately, it wasn't as simple as I hoped; the tracking of source objects
had to be duplicated, because they are exposed by the "source" getter and the
"newErrorWithProperties" method.  All in all, I'm not sure if it's worth it.

[Brian Wilkerson, 2014-10-06 14:10:08]

I agree that this doesn't look like we're improving anything significantly. I
suspect that I was thinking of the NullErrorListener when we were talking about
it.

https://codereview.chromium.org/628053002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/error.dart (right):

https://codereview.chromium.org/628053002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/error.dart:2123: abstract class ErrorReporter {
I'm not sure why we needed to make this an abstract class. NullErrorReporter
could have implemented the original definition.

[Paul Berry, 2014-10-06 16:44:39]

Yeah, a NullErrorListener makes a lot more sense.  PTAL.

https://codereview.chromium.org/628053002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/error.dart (right):

https://codereview.chromium.org/628053002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/error.dart:2123: abstract class ErrorReporter {
On 2014/10/06 14:10:08, Brian Wilkerson wrote:
> I'm not sure why we needed to make this an abstract class. NullErrorReporter
> could have implemented the original definition.

Since NullErrorReporter is in the same library as ErrorReporter, it would also
have to have implemented ErrorReporter._hasEqualTypeNames,
ErrorReporter._errorListener, and ErrorReporter._convertTypeNames.  I suppose I
could have just left these methods empty, but that seemed clumsy.

Guess it's a moot point now, though :)

[Brian Wilkerson, 2014-10-06 16:49:41]

LGTM

https://codereview.chromium.org/628053002/diff/20001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/error.dart (right):

https://codereview.chromium.org/628053002/diff/20001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/error.dart:2781: class NullErrorListener
implements AnalysisErrorListener {
Or use the poorly named but existing class
AnalysisErrorListener_NULL_LISTENER...

[Paul Berry, 2014-10-06 16:56:53]

https://codereview.chromium.org/628053002/diff/20001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/error.dart (right):

https://codereview.chromium.org/628053002/diff/20001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/error.dart:2781: class NullErrorListener
implements AnalysisErrorListener {
On 2014/10/06 16:49:41, Brian Wilkerson wrote:
> Or use the poorly named but existing class
> AnalysisErrorListener_NULL_LISTENER...

Done.

[Paul Berry, 2014-10-06 16:57:17]

Committed patchset #2 (id:20001) manually as 40940 (presubmit successful).