Issue 628023003: Move Engine to Server element / error converters into protocol_server.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 628023003: Move Engine to Server element / error converters into protocol_server.dart (Closed)

Created:
6 years, 2 months ago by scheglov

Modified:
6 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move Engine to Server element / error converters into protocol_server.dart Also move the corrsponding tests. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40983

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+223 lines, -597 lines)			Patch
D	pkg/analysis_server/lib/src/computer/element.dart	View	1 chunk	+0 lines, -113 lines	0 comments	Download
M	pkg/analysis_server/lib/src/protocol_server.dart	View	5 chunks	+103 lines, -3 lines	1 comment	Download
M	pkg/analysis_server/lib/src/search/type_hierarchy.dart	View	4 chunks	+10 lines, -8 lines	0 comments	Download
D	pkg/analysis_server/test/computer/element_test.dart	View	1 chunk	+0 lines, -323 lines	0 comments	Download
D	pkg/analysis_server/test/computer/error_test.dart	View	1 chunk	+0 lines, -106 lines	0 comments	Download
D	pkg/analysis_server/test/computer/test_all.dart	View	1 chunk	+0 lines, -22 lines	0 comments	Download
A +	pkg/analysis_server/test/protocol_server_test.dart	View	8 chunks	+108 lines, -20 lines	0 comments	Download
M	pkg/analysis_server/test/test_all.dart	View	4 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/628023003/diff/1/pkg/analysis_server/lib/src/protocol_server.dart File pkg/analysis_server/lib/src/protocol_server.dart (right): https://codereview.chromium.org/628023003/diff/1/pkg/analysis_server/lib/src/protocol_server.dart#newcode392 pkg/analysis_server/lib/src/protocol_server.dart:392: // TODO(scheglov) add isAbstract to Element API It ...

6 years, 2 months ago (2014-10-07 22:21:55 UTC) #2

scheglov

6 years, 2 months ago (2014-10-07 22:25:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40983 (presubmit successful).

Expand Messages | Collapse Messages