Issue 627403002: Asjusting unittest comments with one-line summaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 627403002: Asjusting unittest comments with one-line summaries (Closed)

Created:
6 years, 2 months ago by srawlins

Modified:
6 years, 2 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -19 lines)			Patch
	M	pkg/unittest/lib/unittest.dart	View	1 2	8 chunks	+35 lines, -19 lines	0 comments	Download

Total messages: 4 (1 generated)

srawlins

Hi Bob, let me know if this review should go to someone else.

6 years, 2 months ago (2014-10-06 04:21:00 UTC) #2

Bob Nystrom

LGTM! You can also send unittest/matcher reviews to kevmoo@ or sigmund@.

6 years, 2 months ago (2014-10-07 17:57:38 UTC) #3

srawlins

6 years, 2 months ago (2014-10-07 18:50:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 40968 (presubmit successful).