Uncomment and clean up engine_test.dart

Uncomment and clean up engine_test.dart

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=40913

[Brian Wilkerson, 2014-10-05 17:54:37]

LGTM. There are a lot of engine tests here that I still have commented out,
which could also account for the differences in counts.

https://codereview.chromium.org/627133002/diff/20001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/627133002/diff/20001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:1007: IncrementalAnalysisCache get
test_incrementalAnalysisCache {
I really dislike having methods that exist only for testing be prefixed with
"test_". To my JUnit trained eye this makes them look like test methods. I don't
like having these methods at all, but I don't know of a reasonable alternative.
(No, this comment isn't particularly actionable, I'm just complaining...)

[scheglov, 2014-10-05 19:55:17]

Committed patchset #2 (id:20001) manually as 40913 (presubmit successful).

[scheglov, 2014-10-05 19:55:37]

https://codereview.chromium.org/627133002/diff/20001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/627133002/diff/20001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:1007: IncrementalAnalysisCache get
test_incrementalAnalysisCache {
On 2014/10/05 17:54:37, Brian Wilkerson wrote:
> I really dislike having methods that exist only for testing be prefixed with
> "test_". To my JUnit trained eye this makes them look like test methods. I
don't
> like having these methods at all, but I don't know of a reasonable
alternative.
> (No, this comment isn't particularly actionable, I'm just complaining...)

  These methods are used instead of using reflection in Java.
  You're welcome to rename them later :-)