Issue 626523002: VM: Improve generated code for loading the current context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 626523002: VM: Improve generated code for loading the current context. (Closed)

Created:
6 years, 2 months ago by Florian Schneider

Modified:
6 years, 2 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

VM: Improve generated code for loading the current context. Instead of emitting a move instruction, specify CTX as result register. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40884

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -76 lines)			Patch
M	runtime/vm/intermediate_language.cc	View	3 chunks	+21 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download

Total messages: 4 (1 generated)

Vyacheslav Egorov (Google)

LGTM! I am surprised we did not do this before.

6 years, 2 months ago (2014-10-02 15:53:35 UTC) #3

Florian Schneider

6 years, 2 months ago (2014-10-02 16:02:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r40884 (presubmit successful).