Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 625923003: Add Domain handler with startup and shutdown stubs (Closed)

Created:
6 years, 2 months ago by lukechurch
Modified:
6 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add Domain handler with startup and shutdown stubs As per discussion this is a proposal for an api to be implemented by server to notify domains that need to be called before handling requests will be started and after it has finished BUG= R=brianwilkerson@google.com, danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=40911

Patch Set 1 #

Patch Set 2 : Adjust comments #

Patch Set 3 : Add default empty impls for startup and shutdown #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M dart/pkg/analysis_server/lib/src/protocol.dart View 1 2 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
lukechurch
As discussed, here are some stubs to be hooked in. I'm not sure that I'm ...
6 years, 2 months ago (2014-10-03 12:57:03 UTC) #2
Brian Wilkerson
For the sake of domains that have no startup and/or shutdown behavior, I would choose ...
6 years, 2 months ago (2014-10-03 13:17:44 UTC) #3
lukechurch
On 2014/10/03 13:17:44, Brian Wilkerson wrote: > For the sake of domains that have no ...
6 years, 2 months ago (2014-10-03 14:05:28 UTC) #4
lukechurch
address comments.
6 years, 2 months ago (2014-10-03 14:21:59 UTC) #5
Brian Wilkerson
> ... is there any reason to have RequestHandler as a separate abstract class? Not ...
6 years, 2 months ago (2014-10-03 15:06:58 UTC) #6
danrubel
LGTM
6 years, 2 months ago (2014-10-04 21:12:54 UTC) #7
lukechurch
6 years, 2 months ago (2014-10-04 21:24:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 40911 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698