Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 62443006: Fix an analyzer error in http and barback. (Closed)

Created:
7 years, 1 month ago by nweiz
Modified:
7 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix an analyzer error in http and barback. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30331

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M pkg/barback/lib/src/utils.dart View 1 1 chunk +4 lines, -1 line 0 comments Download
M pkg/http/lib/src/utils.dart View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
7 years, 1 month ago (2013-11-16 00:57:28 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/62443006/diff/1/pkg/barback/lib/src/utils.dart File pkg/barback/lib/src/utils.dart (right): https://codereview.chromium.org/62443006/diff/1/pkg/barback/lib/src/utils.dart#newcode89 pkg/barback/lib/src/utils.dart:89: return new Uint8List.view((input as TypedData).buffer); I thought the ...
7 years, 1 month ago (2013-11-16 00:59:16 UTC) #2
nweiz
https://codereview.chromium.org/62443006/diff/1/pkg/barback/lib/src/utils.dart File pkg/barback/lib/src/utils.dart (right): https://codereview.chromium.org/62443006/diff/1/pkg/barback/lib/src/utils.dart#newcode89 pkg/barback/lib/src/utils.dart:89: return new Uint8List.view((input as TypedData).buffer); On 2013/11/16 00:59:16, Bob ...
7 years, 1 month ago (2013-11-16 01:12:49 UTC) #3
nweiz
7 years, 1 month ago (2013-11-16 01:13:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r30331 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698