Issue 62443002: VM: Fix double comparisons using != and NaN in optimized code.

Issue 62443002: VM: Fix double comparisons using != and NaN in optimized code. (Closed)

Created:
7 years, 1 month ago by fschneider

Modified:
7 years, 1 month ago

Reviewers:
regis, Florian Schneider, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org, regis

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

VM: Fix double comparisons using != and NaN in optimized code. With a double x x == double.NAN should false and x != double.NAN should be true. TEST=tests/language/double_nan_comparison_test.dart BUG=https://code.google.com/p/dart/issues/detail?id=14867 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=29985

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -5 lines)			Patch
M	runtime/vm/flow_graph_compiler_arm.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
A	tests/language/double_nan_comparison_test.dart	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/62443002/diff/1/tests/language/double_nan_comparison_test.dart File tests/language/double_nan_comparison_test.dart (right): https://codereview.chromium.org/62443002/diff/1/tests/language/double_nan_comparison_test.dart#newcode1 tests/language/double_nan_comparison_test.dart:1: // Copyright (c) 2011, the Dart project authors. ...

7 years, 1 month ago (2013-11-06 18:20:27 UTC) #2

Florian Schneider

https://codereview.chromium.org/62443002/diff/1/tests/language/double_nan_comparison_test.dart File tests/language/double_nan_comparison_test.dart (right): https://codereview.chromium.org/62443002/diff/1/tests/language/double_nan_comparison_test.dart#newcode1 tests/language/double_nan_comparison_test.dart:1: // Copyright (c) 2011, the Dart project authors. Please ...

7 years, 1 month ago (2013-11-06 18:28:18 UTC) #3

fschneider

Committed patchset #2 manually as r29985 (presubmit successful).

7 years, 1 month ago (2013-11-06 18:28:45 UTC) #4

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages