Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 624103003: Make deserialization more regular as prep for deferring canonicalization for types/instances. (Closed)

Created:
6 years, 2 months ago by rmacnak
Modified:
6 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make deserialization more regular as prep for deferring canonicalization for types/instances. BUG=http://dartbug.com/21079 R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41089

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -53 lines) Patch
M runtime/vm/raw_object.h View 1 1 chunk +5 lines, -2 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 17 chunks +80 lines, -51 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
rmacnak
6 years, 2 months ago (2014-10-06 20:11:34 UTC) #2
rmacnak
6 years, 2 months ago (2014-10-13 17:06:28 UTC) #3
siva
lgtm https://chromiumcodereview.appspot.com/624103003/diff/20001/runtime/vm/raw_object_snapshot.cc File runtime/vm/raw_object_snapshot.cc (right): https://chromiumcodereview.appspot.com/624103003/diff/20001/runtime/vm/raw_object_snapshot.cc#newcode2695 runtime/vm/raw_object_snapshot.cc:2695: I think we should retain the comment that ...
6 years, 2 months ago (2014-10-13 23:28:17 UTC) #4
rmacnak
https://chromiumcodereview.appspot.com/624103003/diff/20001/runtime/vm/raw_object_snapshot.cc File runtime/vm/raw_object_snapshot.cc (right): https://chromiumcodereview.appspot.com/624103003/diff/20001/runtime/vm/raw_object_snapshot.cc#newcode2695 runtime/vm/raw_object_snapshot.cc:2695: On 2014/10/13 23:28:17, siva wrote: > I think we ...
6 years, 2 months ago (2014-10-14 00:49:44 UTC) #5
rmacnak
6 years, 2 months ago (2014-10-14 01:16:06 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 41089 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698