Issue 623823003: Fix carry out calculation in ARM simulator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 623823003: Fix carry out calculation in ARM simulator. (Closed)

Created:
6 years, 2 months ago by regis

Modified:
6 years, 2 months ago

Reviewers:
zra, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix carry out calculation in ARM simulator. Add a regression test. Simplify overflow calculation in ARM simulator. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=40918

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -57 lines)			Patch
M	runtime/vm/assembler_arm_test.cc	View	2 chunks	+52 lines, -0 lines	0 comments	Download
M	runtime/vm/simulator_arm.h	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	runtime/vm/simulator_arm.cc	View	10 chunks	+33 lines, -51 lines	0 comments	Download

Total messages: 4 (1 generated)

regis

I will fix the arm64 simulator next week, because it looks broken too. -- Regis

6 years, 2 months ago (2014-10-02 23:27:46 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r40918.