Properly escape angle brackets and find their corresponding links in docgen.

Properly escape angle brackets and find their corresponding links in docgen.
BUG=
R=alanknight@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30015

[Emily Fortuna, 2013-11-06 20:56:31]

https://codereview.chromium.org/62353004/diff/30001/pkg/docgen/pubspec.yaml
File pkg/docgen/pubspec.yaml (right):

https://codereview.chromium.org/62353004/diff/30001/pkg/docgen/pubspec.yaml#n...
pkg/docgen/pubspec.yaml:8: ref: emilysEdits
I have a pull request in to update the default markdown package, but I'm waiting
to hear back. Until then, I forked the repo and am using a custom version I
edited.

[Alan Knight, 2013-11-06 21:19:04]

https://codereview.chromium.org/62353004/diff/30001/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/62353004/diff/30001/pkg/docgen/lib/docgen.dar...
pkg/docgen/lib/docgen.dart:546: var alphanumeric = new RegExp('[a-zA-Z0-9]');
Should this also allow _ as legal in names?

Also, library names can have dots in them. So will this handle

[stuff.stuff_handlers.Stuff<stuff.stuff_handlers.OtherStuff>]  ?

https://codereview.chromium.org/62353004/diff/30001/pkg/docgen/lib/docgen.dar...
pkg/docgen/lib/docgen.dart:552: curName = curName.substring(index +
LESS_THAN.length);
This whole section is pretty hard to follow. Can it be either re-organized to be
easier to follow or put in some more comments as to what's going on.

https://codereview.chromium.org/62353004/diff/30001/pkg/docgen/lib/docgen.dar...
pkg/docgen/lib/docgen.dart:576: while (childrenElements.length  > 0) {
Couldn't this be written as a loop over childrenElements? It doesn't seem like
we modify it in the middle or use the result once we're done.

[Emily Fortuna, 2013-11-06 23:41:45]

refactored. PTAL!

[Alan Knight, 2013-11-06 23:54:18]

lgtm. Couple of nits.

https://codereview.chromium.org/62353004/diff/90001/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/62353004/diff/90001/pkg/docgen/lib/docgen.dar...
pkg/docgen/lib/docgen.dart:544: /// bold <em>.
Maybe provide an example of an input and output, just to make it clearer.

https://codereview.chromium.org/62353004/diff/90001/pkg/docgen/lib/docgen.dar...
pkg/docgen/lib/docgen.dart:545: List<String> _tokenizeComplexReference(String
curName) {
nit: If we're not re-assigning to it, isn't it just "name"?

https://codereview.chromium.org/62353004/diff/90001/pkg/docgen/lib/docgen.dar...
pkg/docgen/lib/docgen.dart:548: var curIndex = 0;
and this could probably just be "index"

[Emily Fortuna, 2013-11-07 00:04:55]

Committed patchset #3 manually as r30015 (presubmit successful).