Issue 623433002: Don't perform OSR on intrinsified methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 623433002: Don't perform OSR on intrinsified methods. (Closed)

Created:
6 years, 2 months ago by Florian Schneider

Modified:
6 years, 2 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Don't perform OSR on intrinsified methods. Some non-native methods have intrinsic code (e.g. in Bigint) and can't be entered via OSR. BUG=dartbug.com/21186 R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40838

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	runtime/vm/code_generator.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	runtime/vm/intrinsifier.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Vyacheslav Egorov (Google)

LGTM (maybe add assertion to the intensifier that we are not compiling for OSR?)

6 years, 2 months ago (2014-10-01 13:06:29 UTC) #3

Florian Schneider

On 2014/10/01 13:06:29, Vyacheslav Egorov (Google) wrote: > LGTM > > (maybe add assertion to ...

6 years, 2 months ago (2014-10-01 14:25:48 UTC) #4

Florian Schneider

6 years, 2 months ago (2014-10-01 14:50:11 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as r40838 (presubmit successful).