Use the runtime for generic subsitution of variable types, return types, parameter types.

Use the runtime for generic subsitution of variable types, return types, parameter types.

BUG=http://dartbug.com/14613
BUG=http://dartbug.com/14156
R=gbracha@google.com, regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30120

[rmacnak, 2013-11-06 18:40:32]

https://codereview.chromium.org/62273003/diff/60001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/62273003/diff/60001/runtime/lib/mirrors.cc#ne...
runtime/lib/mirrors.cc:1911: if (instantiator.IsNull()) {
Null in the case the method is top-level, libraries thankfully being
non-generic.

[gbracha, 2013-11-06 18:44:02]

tests lgtm

[regis, 2013-11-06 19:06:07]

https://codereview.chromium.org/62273003/diff/60001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/62273003/diff/60001/runtime/lib/mirrors.cc#ne...
runtime/lib/mirrors.cc:1911: if (instantiator.IsNull()) {
You could have a null instantiator, because the instantiating class is raw. In
this case, you still want to instantiate your generic result type with dynamic.
So you should replace
if (instantiator.IsNull()) {
with
if (type.IsInstantiated()) {

Of course, this requires your InstantiateType function to handle a null
instantiator correctly. The corresponding calls in object.cc do the right thing.

https://codereview.chromium.org/62273003/diff/60001/runtime/lib/mirrors.cc#ne...
runtime/lib/mirrors.cc:1968: if (instantiator.IsNull()) {
ditto

https://codereview.chromium.org/62273003/diff/60001/runtime/lib/mirrors.cc#ne...
runtime/lib/mirrors.cc:1981: if (instantiator.IsNull()) {
ditto

https://codereview.chromium.org/62273003/diff/60001/runtime/lib/mirrors_impl....
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/62273003/diff/60001/runtime/lib/mirrors_impl....
runtime/lib/mirrors_impl.dart:1217: _returnType = owner;
Why don't you instantiate in this case?

[rmacnak, 2013-11-07 19:56:00]

https://codereview.chromium.org/62273003/diff/60001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/62273003/diff/60001/runtime/lib/mirrors.cc#ne...
runtime/lib/mirrors.cc:1911: if (instantiator.IsNull()) {
On 2013/11/06 19:06:07, regis wrote:
> You could have a null instantiator, because the instantiating class is raw. In
> this case, you still want to instantiate your generic result type with
dynamic.
> So you should replace
> if (instantiator.IsNull()) {
> with
> if (type.IsInstantiated()) {
> 
> Of course, this requires your InstantiateType function to handle a null
> instantiator correctly. The corresponding calls in object.cc do the right
thing.

The instantiator here isn't a type vector, it's the reflected type of the
enclosing class mirror, which is never null. Still, it seems like adjusting
InstantiateType is the right way to go.

Also cleaned-up substitution for function types to use the runtime and pass the
stronger asserts.

[regis, 2013-11-08 16:46:38]

LGTM

[rmacnak, 2013-11-08 17:55:08]

Committed patchset #4 manually as r30120 (presubmit successful).

[ahe, 2013-11-11 10:27:02]

Tests LGTM!