Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 622523003: Update co19 status for co19 roll to r786. (Closed)

Created:
6 years, 2 months ago by Bill Hesse
Modified:
6 years, 2 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update co19 status for co19 roll to r786. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=40836

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M dart/tests/co19/co19-co19.status View 1 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/co19/co19-dartium.status View 4 chunks +12 lines, -3 lines 0 comments Download
M dart/tests/html/html.status View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bill Hesse
6 years, 2 months ago (2014-10-01 13:27:26 UTC) #2
ricow1
lgtm https://codereview.chromium.org/622523003/diff/1/dart/tests/co19/co19-co19.status File dart/tests/co19/co19-co19.status (right): https://codereview.chromium.org/622523003/diff/1/dart/tests/co19/co19-co19.status#newcode82 dart/tests/co19/co19-co19.status:82: [ $compiler != dartanalyzer && $compiler != dart2analyzer ...
6 years, 2 months ago (2014-10-01 13:30:34 UTC) #3
Bill Hesse
https://codereview.chromium.org/622523003/diff/1/dart/tests/co19/co19-co19.status File dart/tests/co19/co19-co19.status (right): https://codereview.chromium.org/622523003/diff/1/dart/tests/co19/co19-co19.status#newcode82 dart/tests/co19/co19-co19.status:82: [ $compiler != dartanalyzer && $compiler != dart2analyzer && ...
6 years, 2 months ago (2014-10-01 13:39:06 UTC) #4
Bill Hesse
6 years, 2 months ago (2014-10-01 13:42:28 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as r40836 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698