Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 621813002: Mac no longer fire bogus events. Fix Mac watcher. (Closed)

Created:
6 years, 2 months ago by Anders Johnsen
Modified:
6 years, 2 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mac no longer fire bogus events. Fix Mac watcher. This is a re-apply of r37162. BUG= R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=41220

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -68 lines) Patch
M pkg/watcher/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/watcher/lib/src/directory_watcher/mac_os.dart View 4 chunks +5 lines, -67 lines 0 comments Download
M pkg/watcher/pubspec.yaml View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Anders Johnsen
6 years, 2 months ago (2014-10-01 11:21:26 UTC) #2
nweiz
https://codereview.chromium.org/621813002/diff/1/pkg/watcher/pubspec.yaml File pkg/watcher/pubspec.yaml (right): https://codereview.chromium.org/621813002/diff/1/pkg/watcher/pubspec.yaml#newcode2 pkg/watcher/pubspec.yaml:2: version: 0.9.5-dev Why isn't this 0.9.4-dev? Or just 0.9.4? ...
6 years, 2 months ago (2014-10-13 18:45:31 UTC) #3
Anders Johnsen
PTAL https://codereview.chromium.org/621813002/diff/1/pkg/watcher/pubspec.yaml File pkg/watcher/pubspec.yaml (right): https://codereview.chromium.org/621813002/diff/1/pkg/watcher/pubspec.yaml#newcode2 pkg/watcher/pubspec.yaml:2: version: 0.9.5-dev On 2014/10/13 18:45:31, nweiz wrote: > ...
6 years, 2 months ago (2014-10-20 11:28:47 UTC) #4
nweiz
lgtm
6 years, 2 months ago (2014-10-20 20:03:28 UTC) #5
Anders Johnsen
6 years, 2 months ago (2014-10-21 06:06:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as 41220 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698