Update co19 test suite to r786.

Update co19 test suite to r786.

R=kustermann@google.com, ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40832

[Bill Hesse, 2014-10-01 08:53:23]

whesse@google.com changed reviewers:
+ kustermann@google.com

[ricow1, 2014-10-01 09:15:42]

ricow@google.com changed reviewers:
+ ricow@google.com

[ricow1, 2014-10-01 09:15:43]

lgtm

https://codereview.chromium.org/621753002/diff/1/dart/tests/co19/co19-analyze...
File dart/tests/co19/co19-analyzer.status (right):

https://codereview.chromium.org/621753002/diff/1/dart/tests/co19/co19-analyze...
dart/tests/co19/co19-analyzer.status:270: # co19 issues filed for these tests.
that is explicitly on the line below, remove comment

https://codereview.chromium.org/621753002/diff/1/dart/tests/co19/co19-dart2da...
File dart/tests/co19/co19-dart2dart.status (right):

https://codereview.chromium.org/621753002/diff/1/dart/tests/co19/co19-dart2da...
dart/tests/co19/co19-dart2dart.status:14:
LibTest/async/DeferredLibrary/DeferredLibrary_A01_t01: Pass # co19 issue 718
remove it if passes

[kustermann, 2014-10-01 09:17:17]

lgtm with comment about PASS

https://codereview.chromium.org/621753002/diff/1/dart/tests/co19/co19-analyze...
File dart/tests/co19/co19-analyzer.status (right):

https://codereview.chromium.org/621753002/diff/1/dart/tests/co19/co19-analyze...
dart/tests/co19/co19-analyzer.status:270: # co19 issues filed for these tests.
On 2014/10/01 09:15:42, ricow1 wrote:
> that is explicitly on the line below, remove comment

I've complained about the block comments several times as well. They get out of
date pretty quickly and don't add much value.

https://codereview.chromium.org/621753002/diff/1/dart/tests/co19/co19-dart2da...
File dart/tests/co19/co19-dart2dart.status (right):

https://codereview.chromium.org/621753002/diff/1/dart/tests/co19/co19-dart2da...
dart/tests/co19/co19-dart2dart.status:14:
LibTest/async/DeferredLibrary/DeferredLibrary_A01_t01: Pass # co19 issue 718
Pass? You should remove this - and maybe add another suppression to where it
actually fails (if necessary).

[Bill Hesse, 2014-10-01 09:24:02]

https://codereview.chromium.org/621753002/diff/1/dart/tests/co19/co19-analyze...
File dart/tests/co19/co19-analyzer.status (right):

https://codereview.chromium.org/621753002/diff/1/dart/tests/co19/co19-analyze...
dart/tests/co19/co19-analyzer.status:270: # co19 issues filed for these tests.
On 2014/10/01 09:17:17, kustermann wrote:
> On 2014/10/01 09:15:42, ricow1 wrote:
> > that is explicitly on the line below, remove comment
> 
> I've complained about the block comments several times as well. They get out
of
> date pretty quickly and don't add much value.

We have individual comments on each line, but these header comments are very
useful for me when navigating through the file, to find the place to add
something.  For the co19-roll comments, they mark the end of one alphebetized
section, and the start of a new alphebetized section.  They are not replacing
the fact that each line has a comment, just making the different sections
visible.  I don't see how they would be out of date, for these type of sections.

It certainly makes sense to me to put the issues where a bug has been filed in a
different place than the untriaged bugs, and it is nice to have a label for that
place.

https://codereview.chromium.org/621753002/diff/1/dart/tests/co19/co19-dart2da...
File dart/tests/co19/co19-dart2dart.status (right):

https://codereview.chromium.org/621753002/diff/1/dart/tests/co19/co19-dart2da...
dart/tests/co19/co19-dart2dart.status:14:
LibTest/async/DeferredLibrary/DeferredLibrary_A01_t01: Pass # co19 issue 718
On 2014/10/01 09:15:42, ricow1 wrote:
> remove it if passes

It is marked as fail on a higher level, in the co19-co19.status file.  It fails
on all other platforms other than this one.

If you really don't like this here, then We could mark it as pass/fail here, or
make a new category in co19-co19.status [ $compiler != dart2dart ].

[Bill Hesse, 2014-10-01 09:32:33]

https://codereview.chromium.org/621753002/diff/1/dart/tests/co19/co19-analyze...
File dart/tests/co19/co19-analyzer.status (right):

https://codereview.chromium.org/621753002/diff/1/dart/tests/co19/co19-analyze...
dart/tests/co19/co19-analyzer.status:270: # co19 issues filed for these tests.
On 2014/10/01 09:24:02, Bill Hesse wrote:
> On 2014/10/01 09:17:17, kustermann wrote:
> > On 2014/10/01 09:15:42, ricow1 wrote:
> > > that is explicitly on the line below, remove comment
> > 
> > I've complained about the block comments several times as well. They get out
> of
> > date pretty quickly and don't add much value.
> 
> We have individual comments on each line, but these header comments are very
> useful for me when navigating through the file, to find the place to add
> something.  For the co19-roll comments, they mark the end of one alphebetized
> section, and the start of a new alphebetized section.  They are not replacing
> the fact that each line has a comment, just making the different sections
> visible.  I don't see how they would be out of date, for these type of
sections.
> 
> It certainly makes sense to me to put the issues where a bug has been filed in
a
> different place than the untriaged bugs, and it is nice to have a label for
that
> place.

Comment line removed.

https://codereview.chromium.org/621753002/diff/1/dart/tests/co19/co19-dart2da...
File dart/tests/co19/co19-dart2dart.status (right):

https://codereview.chromium.org/621753002/diff/1/dart/tests/co19/co19-dart2da...
dart/tests/co19/co19-dart2dart.status:14:
LibTest/async/DeferredLibrary/DeferredLibrary_A01_t01: Pass # co19 issue 718
On 2014/10/01 09:24:02, Bill Hesse wrote:
> On 2014/10/01 09:15:42, ricow1 wrote:
> > remove it if passes
> 
> It is marked as fail on a higher level, in the co19-co19.status file.  It
fails
> on all other platforms other than this one.
> 
> If you really don't like this here, then We could mark it as pass/fail here,
or
> make a new category in co19-co19.status [ $compiler != dart2dart ].

Pass removed from this file, new section added to co19-co19.status to hold this
test.

[Bill Hesse, 2014-10-01 09:36:44]

Committed patchset #2 (id:20001) manually as r40832 (presubmit successful).