Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 621743004: Fix update_homebrew script for releasing Dart on Mac using homebrew. (Closed)

Created:
6 years, 2 months ago by Bill Hesse
Modified:
6 years, 2 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Fix update_homebrew script for releasing Dart on Mac using homebrew. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=40837

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M tools/apps/update_homebrew/bin/update_homebrew.dart View 3 chunks +6 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
https://codereview.chromium.org/621743004/diff/1/tools/apps/update_homebrew/bin/update_homebrew.dart File tools/apps/update_homebrew/bin/update_homebrew.dart (left): https://codereview.chromium.org/621743004/diff/1/tools/apps/update_homebrew/bin/update_homebrew.dart#oldcode94 tools/apps/update_homebrew/bin/update_homebrew.dart:94: .then((_) => runGit(['add', '${channel}_info.rb'])) Now that the files are ...
6 years, 2 months ago (2014-10-01 14:18:43 UTC) #2
ricow1
lgtm
6 years, 2 months ago (2014-10-01 14:20:17 UTC) #3
Bill Hesse
6 years, 2 months ago (2014-10-01 14:23:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40837 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698