Issue 62103010: Properly handle leading zeros in pub version numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 62103010: Properly handle leading zeros in pub version numbers. (Closed)

Created:
7 years, 1 month ago by nweiz

Modified:
7 years, 1 month ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Properly handle leading zeros in pub version numbers. R=rnystrom@google.com BUG=13863 Committed: https://code.google.com/p/dart/source/detail?r=30135

Patch Set 3 : code review #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -77 lines)			Patch
	M	sdk/lib/_internal/pub/lib/src/version.dart	View	1	8 chunks	+101 lines, -77 lines	0 comments	Download
	M	sdk/lib/_internal/pub/test/version_test.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Nit, but LGTM. https://codereview.chromium.org/62103010/diff/1/sdk/lib/_internal/pub/lib/src/version.dart File sdk/lib/_internal/pub/lib/src/version.dart (right): https://codereview.chromium.org/62103010/diff/1/sdk/lib/_internal/pub/lib/src/version.dart#newcode182 sdk/lib/_internal/pub/lib/src/version.dart:182: if (other.preRelease.isEmpty && preRelease.isNotEmpty) return -1; ...

7 years, 1 month ago (2013-11-09 01:14:26 UTC) #2

nweiz

https://codereview.chromium.org/62103010/diff/1/sdk/lib/_internal/pub/lib/src/version.dart File sdk/lib/_internal/pub/lib/src/version.dart (right): https://codereview.chromium.org/62103010/diff/1/sdk/lib/_internal/pub/lib/src/version.dart#newcode182 sdk/lib/_internal/pub/lib/src/version.dart:182: if (other.preRelease.isEmpty && preRelease.isNotEmpty) return -1; On 2013/11/09 01:14:26, ...

7 years, 1 month ago (2013-11-09 01:37:07 UTC) #3

nweiz

7 years, 1 month ago (2013-11-09 01:37:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r30135 (presubmit successful).

Expand Messages | Collapse Messages

Issue 62103010: Properly handle leading zeros in pub version numbers. (Closed)

Description

Patch Set 1 #

Patch Set 2 : code review #

Patch Set 3 : code review #

Messages