Add a bigint test with --no_intrinsify.

Split bigint test into several tests.
Add bigint tests with --no_intrinsify.

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41008

[regis, 2014-10-01 23:03:35]

regis@google.com changed reviewers:
+ iposva@google.com

[Ivan Posva, 2014-10-06 07:25:29]

First round of comments.

-Ivan

https://codereview.chromium.org/620943002/diff/20001/tests/corelib/big_intege...
File tests/corelib/big_integer_no_intrinsify_vm_test.dart (right):

https://codereview.chromium.org/620943002/diff/20001/tests/corelib/big_intege...
tests/corelib/big_integer_no_intrinsify_vm_test.dart:6: //
VMOptions=--no_intrinsify
This file is not needed after all. We just need to add multiple lines of
VMOptions= into the original test file.

https://codereview.chromium.org/620943002/diff/20001/tests/corelib/big_intege...
File tests/corelib/big_integer_vm_test.dart (right):

https://codereview.chromium.org/620943002/diff/20001/tests/corelib/big_intege...
tests/corelib/big_integer_vm_test.dart:1635: main() {
We should split this large test into sub pieces to get a handle on the test
execution time.

[regis, 2014-10-06 09:57:51]

I still get timeouts for simmips for some tests (see status file). I'll
investigate some more when writing the MIPS intrinsics.

https://codereview.chromium.org/620943002/diff/20001/tests/corelib/big_intege...
File tests/corelib/big_integer_no_intrinsify_vm_test.dart (right):

https://codereview.chromium.org/620943002/diff/20001/tests/corelib/big_intege...
tests/corelib/big_integer_no_intrinsify_vm_test.dart:6: //
VMOptions=--no_intrinsify
On 2014/10/06 07:25:29, Ivan Posva wrote:
> This file is not needed after all. We just need to add multiple lines of
> VMOptions= into the original test file.

Done.

https://codereview.chromium.org/620943002/diff/20001/tests/corelib/big_intege...
File tests/corelib/big_integer_vm_test.dart (right):

https://codereview.chromium.org/620943002/diff/20001/tests/corelib/big_intege...
tests/corelib/big_integer_vm_test.dart:1635: main() {
On 2014/10/06 07:25:29, Ivan Posva wrote:
> We should split this large test into sub pieces to get a handle on the test
> execution time.

Done.

[Ivan Posva, 2014-10-09 08:36:30]

LGTM -ip

https://codereview.chromium.org/620943002/diff/60001/tests/corelib/corelib.st...
File tests/corelib/corelib.status (right):

https://codereview.chromium.org/620943002/diff/60001/tests/corelib/corelib.st...
tests/corelib/corelib.status:109: big_integer_huge_mul_vm_test: Pass, Crash, OK
# VM specific test.
For VM specific tests it would make more sense to just Skip.

[regis, 2014-10-09 08:51:46]

Thanks!

https://codereview.chromium.org/620943002/diff/60001/tests/corelib/corelib.st...
File tests/corelib/corelib.status (right):

https://codereview.chromium.org/620943002/diff/60001/tests/corelib/corelib.st...
tests/corelib/corelib.status:109: big_integer_huge_mul_vm_test: Pass, Crash, OK
# VM specific test.
On 2014/10/09 08:36:30, Ivan Posva wrote:
> For VM specific tests it would make more sense to just Skip.

Done.

[regis, 2014-10-09 09:42:41]

Committed patchset #5 (id:80001) manually as r41008 (presubmit successful).