Issue 620573002: Make fields sorting stable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 620573002: Make fields sorting stable. (Closed)

Created:
6 years, 2 months ago by scheglov

Modified:
6 years, 2 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make fields sorting stable. Accidentally found a problem when one of the fields is moved, even though all the fields should not. It seems to be he case because List.sort() is not a stable sort. So, we now use offsets to compare field items. R=paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40821

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	pkg/analysis_server/lib/src/services/correction/sort_members.dart	View		3 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

6 years, 2 months ago (2014-09-30 18:00:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40821 (presubmit successful).

Expand Messages | Collapse Messages