Provide ia32 intrinsics for bigint add, sub, quotient digit estimation, and

Provide ia32 intrinsics for bigint add, sub, quotient digit estimation, and
Montgomery mulMod.
Refactored bigint dart code to allow for the above intrinsics.
Added support for unsigned  division on ia32 and added assembly tests.

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40822

[regis, 2014-09-30 17:06:09]

regis@google.com changed reviewers:
+ johnmccutchan@google.com

[regis, 2014-09-30 17:06:10]

regis@google.com changed reviewers:
+ johnmccutchan@google.com

[regis, 2014-09-30 17:06:10]

John,

This cl also contains your patch for the uint32 boxing/unboxing issue. I can
remove it from this cl before submitting if you prefer.

Thanks,
Regis

[regis, 2014-09-30 17:06:10]

John,

This cl also contains your patch for the uint32 boxing/unboxing issue. I can
remove it from this cl before submitting if you prefer.

Thanks,
Regis

[regis, 2014-09-30 17:06:12]

John,

This cl also contains your patch for the uint32 boxing/unboxing issue. I can
remove it from this cl before submitting if you prefer.

Thanks,
Regis

[Cutch, 2014-09-30 17:52:54]

lgtm

https://codereview.chromium.org/620553002/diff/20001/runtime/lib/bigint.dart
File runtime/lib/bigint.dart (right):

https://codereview.chromium.org/620553002/diff/20001/runtime/lib/bigint.dart#...
runtime/lib/bigint.dart:980: Uint32List args = new Uint32List(2);
Can you cache this Uint32List somewhere so we don't allocate one each time?

https://codereview.chromium.org/620553002/diff/20001/runtime/vm/intrinsifier_...
File runtime/vm/intrinsifier_ia32.cc (right):

https://codereview.chromium.org/620553002/diff/20001/runtime/vm/intrinsifier_...
runtime/vm/intrinsifier_ia32.cc:1000: Label add_loop;
sub_loop?

[regis, 2014-09-30 18:35:58]

Thanks!

https://codereview.chromium.org/620553002/diff/20001/runtime/lib/bigint.dart
File runtime/lib/bigint.dart (right):

https://codereview.chromium.org/620553002/diff/20001/runtime/lib/bigint.dart#...
runtime/lib/bigint.dart:980: Uint32List args = new Uint32List(2);
On 2014/09/30 17:52:54, Cutch wrote:
> Can you cache this Uint32List somewhere so we don't allocate one each time?

There is no optimal place to cache this array, and I removed the ugly global one
I used to have. The cost of an allocation is negligible, compared to the cost of
this whole function.

https://codereview.chromium.org/620553002/diff/20001/runtime/vm/intrinsifier_...
File runtime/vm/intrinsifier_ia32.cc (right):

https://codereview.chromium.org/620553002/diff/20001/runtime/vm/intrinsifier_...
runtime/vm/intrinsifier_ia32.cc:1000: Label add_loop;
On 2014/09/30 17:52:54, Cutch wrote:
> sub_loop?

Done.

[regis, 2014-09-30 18:49:48]

Committed patchset #3 (id:40001) manually as r40822 (presubmit successful).