Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 620293002: refactor library prefix suggestion generation (Closed)

Created:
6 years, 2 months ago by danrubel
Modified:
6 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

refactor library prefix suggestion generation so the imported_computer is responsible for all suggestions based upon import directives. BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40900

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -28 lines) Patch
M pkg/analysis_server/lib/src/services/completion/imported_computer.dart View 2 chunks +15 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 2 chunks +0 lines, -21 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/imported_computer_test.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/analysis_server/test/services/completion/local_computer_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years, 2 months ago (2014-10-03 05:19:25 UTC) #2
scheglov
lgtm
6 years, 2 months ago (2014-10-03 14:03:12 UTC) #3
danrubel
6 years, 2 months ago (2014-10-03 16:02:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 40900 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698