Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 620013002: improve completion test failure message by adding node info (Closed)

Created:
6 years, 2 months ago by danrubel
Modified:
6 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

improve completion test failure message by adding node info BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40885

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge #

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 2 6 chunks +27 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
danrubel
6 years, 2 months ago (2014-10-02 00:06:12 UTC) #2
scheglov
LGTM https://codereview.chromium.org/620013002/diff/1/pkg/analysis_server/test/services/completion/completion_test_util.dart File pkg/analysis_server/test/services/completion/completion_test_util.dart (right): https://codereview.chromium.org/620013002/diff/1/pkg/analysis_server/test/services/completion/completion_test_util.dart#newcode293 pkg/analysis_server/test/services/completion/completion_test_util.dart:293: AstNode node = new NodeLocator.con1(completionOffset).searchWithin(unit); We could remember ...
6 years, 2 months ago (2014-10-02 02:28:09 UTC) #3
danrubel
https://codereview.chromium.org/620013002/diff/1/pkg/analysis_server/test/services/completion/completion_test_util.dart File pkg/analysis_server/test/services/completion/completion_test_util.dart (right): https://codereview.chromium.org/620013002/diff/1/pkg/analysis_server/test/services/completion/completion_test_util.dart#newcode293 pkg/analysis_server/test/services/completion/completion_test_util.dart:293: AstNode node = new NodeLocator.con1(completionOffset).searchWithin(unit); On 2014/10/02 02:28:08, scheglov ...
6 years, 2 months ago (2014-10-02 16:27:17 UTC) #4
danrubel
6 years, 2 months ago (2014-10-02 16:30:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 40885 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698