Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 619723004: Fix following compiler warnings: (Closed)

Created:
6 years, 2 months ago by siva
Modified:
6 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix following compiler warnings: os_win.cc(266) : warning C4018: '>=' : signed/unsigned mismatch stub_code_ia32.cc(89) : warning C4146: unary minus operator applied to unsigned type, result still unsigned stub_code_ia32.cc(213) : warning C4146: unary minus operator applied to unsigned type, result still unsigned stub_code_ia32.cc(317) : warning C4146: unary minus operator applied to unsigned type, result still unsigned crypto_win.cc(5) : warning C4005: '_CRT_RAND_S' : macro redefinition file_win.cc(512) : warning C4101: 'st' : unreferenced local variable BUG=http://dartbug.com/21150 R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=40826

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M runtime/bin/crypto_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/file_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/os_win.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
siva
6 years, 2 months ago (2014-09-30 21:52:09 UTC) #2
rmacnak
https://codereview.chromium.org/619723004/diff/1/runtime/vm/stub_code_ia32.cc File runtime/vm/stub_code_ia32.cc (right): https://codereview.chromium.org/619723004/diff/1/runtime/vm/stub_code_ia32.cc#newcode89 runtime/vm/stub_code_ia32.cc:89: __ AddImmediate(ESP, Immediate(0 - sizeof(NativeArguments))); I think these need ...
6 years, 2 months ago (2014-09-30 22:39:50 UTC) #3
siva
https://codereview.chromium.org/619723004/diff/1/runtime/vm/stub_code_ia32.cc File runtime/vm/stub_code_ia32.cc (right): https://codereview.chromium.org/619723004/diff/1/runtime/vm/stub_code_ia32.cc#newcode89 runtime/vm/stub_code_ia32.cc:89: __ AddImmediate(ESP, Immediate(0 - sizeof(NativeArguments))); On 2014/09/30 22:39:50, rmacnak ...
6 years, 2 months ago (2014-09-30 23:05:36 UTC) #4
rmacnak
LGTM
6 years, 2 months ago (2014-09-30 23:10:43 UTC) #5
siva
6 years, 2 months ago (2014-09-30 23:29:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r40826 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698