Cleanup of scripts after removal of trunk builders.

Cleanup of scripts after removal of trunk builders.

The transition to our channels has been completed, so we can remove all trunk
related special casing code.

R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30051

[ricow1, 2013-11-07 14:09:20]

LGTM

https://codereview.chromium.org/61893007/diff/1/editor/build/build.py
File editor/build/build.py (right):

https://codereview.chromium.org/61893007/diff/1/editor/build/build.py#newcode359
editor/build/build.py:359: #
dart-editor(-be/dev/stable),dart-editor-(win/mac/linux)(-be/dev/stable)
you are missing installer here, so either add it or assume that people can read
the regexp below

https://codereview.chromium.org/61893007/diff/1/editor/build/build.py#newcode901
editor/build/build.py:901: # Create a editor.properties
should we move this down to line 924 for increased readability

https://codereview.chromium.org/61893007/diff/1/editor/build/promote.py
File editor/build/promote.py (right):

https://codereview.chromium.org/61893007/diff/1/editor/build/promote.py#newco...
editor/build/promote.py:27: promote - Will promote builds from raw/signed
locations to release
this is wrong right? we only promote builds from signed locations?

https://codereview.chromium.org/61893007/diff/1/editor/build/promote.py#newco...
editor/build/promote.py:80: # FIXME/TODO(kustermann,ricow): Implement Api
documentation upload/refresh.
Maybe change this to a bug number, we can close it after Seth takes your pull
request

[kustermann, 2013-11-07 15:00:23]

https://codereview.chromium.org/61893007/diff/1/editor/build/build.py
File editor/build/build.py (right):

https://codereview.chromium.org/61893007/diff/1/editor/build/build.py#newcode359
editor/build/build.py:359: #
dart-editor(-be/dev/stable),dart-editor-(win/mac/linux)(-be/dev/stable)
On 2013/11/07 14:09:21, ricow1 wrote:
> you are missing installer here, so either add it or assume that people can
read
> the regexp below

Removed

https://codereview.chromium.org/61893007/diff/1/editor/build/build.py#newcode901
editor/build/build.py:901: # Create a editor.properties
On 2013/11/07 14:09:21, ricow1 wrote:
> should we move this down to line 924 for increased readability

I put it up here, because we need to create this file only once in the editor.
The for loop below loops over all zip files, so we would need to create it
multiple times.

Plus: IMHO the code at line 924 is actually more readable, since it only shows
what we do.

I'll leave it.

https://codereview.chromium.org/61893007/diff/1/editor/build/promote.py
File editor/build/promote.py (right):

https://codereview.chromium.org/61893007/diff/1/editor/build/promote.py#newco...
editor/build/promote.py:27: promote - Will promote builds from raw/signed
locations to release
On 2013/11/07 14:09:21, ricow1 wrote:
> this is wrong right? we only promote builds from signed locations?

As discussed offline, linux builds are not signed so we fetch them from the raw
location.

[kustermann, 2013-11-07 15:05:25]

Committed patchset #2 manually as r30051 (presubmit successful).