Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 618323004: Fix for web_gl statics (Closed)

Created:
6 years, 2 months ago by vsm
Modified:
6 years, 2 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Fix for web_gl statics This was fixed on trunk / 1.7 separately. Here's the same for bleeding_edge: BUG=https://code.google.com/p/dart/issues/detail?id=21173 R=leafp@google.com Committed: https://code.google.com/p/dart/source/detail?r=41045

Patch Set 1 #

Patch Set 2 : Regen #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3080 lines, -4947 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 2 chunks +3 lines, -303 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 3 chunks +1647 lines, -2244 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 4 chunks +992 lines, -2098 lines 0 comments Download
M tools/dom/dom.json View 1 9 chunks +121 lines, -4 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 1 1 chunk +18 lines, -0 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/src/WebGLConstants.dart View 1 chunk +295 lines, -295 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vsm
6 years, 2 months ago (2014-10-09 17:25:04 UTC) #2
Leaf
lgtm
6 years, 2 months ago (2014-10-09 17:35:08 UTC) #3
vsm
6 years, 2 months ago (2014-10-10 16:40:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41045 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698