Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1502)

Issue 61793008: Fix in compound path observer: this fixes the error we saw in our manual testing (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix in compound path observer: this fixes the error we saw in our manual testing of todomvc. Committed: https://code.google.com/p/dart/source/detail?r=30121

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/observe/lib/src/compound_path_observer.dart View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Siggi Cherem (dart-lang)
https://codereview.chromium.org/61793008/diff/1/pkg/observe/lib/src/compound_path_observer.dart File pkg/observe/lib/src/compound_path_observer.dart (right): https://codereview.chromium.org/61793008/diff/1/pkg/observe/lib/src/compound_path_observer.dart#newcode88 pkg/observe/lib/src/compound_path_observer.dart:88: if (_observers.isEmpty) return; turns out that the schedule happens ...
7 years, 1 month ago (2013-11-08 18:37:00 UTC) #1
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-11-08 19:02:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r30121 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698