Issue 61793006: Mark dart:mirrors as having a (slightly) unstable API in the documentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 61793006: Mark dart:mirrors as having a (slightly) unstable API in the documentation. (Closed)

Created:
7 years, 1 month ago by kasperl

Modified:
7 years, 1 month ago

Reviewers:
bakster, ahe

CC:
reviews_dartlang.org, gbracha, rmacnak

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mark dart:mirrors as having a (slightly) unstable API in the documentation. R=ahe@google.com, bak@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30106

Patch Set 2 : Address review feedback. #

Patch Set 3 : it therefore -> therefore it #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	sdk/lib/_internal/libraries.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	sdk/lib/mirrors/mirrors.dart	View	1 2	3 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bakster

LGTM, Lars https://codereview.chromium.org/61793006/diff/1/sdk/lib/mirrors/mirrors.dart File sdk/lib/mirrors/mirrors.dart (right): https://codereview.chromium.org/61793006/diff/1/sdk/lib/mirrors/mirrors.dart#newcode55 sdk/lib/mirrors/mirrors.dart:55: * support all operations yet. - Remove ...

7 years, 1 month ago (2013-11-08 10:32:33 UTC) #2

kasperl

7 years, 1 month ago (2013-11-08 11:38:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r30106 (presubmit successful).