Fix pub.

Fix pub.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=40768

[Johnni Winther, 2014-09-29 13:01:23]

johnniwinther@google.com changed reviewers:
+ rnystrom@google.com

[Johnni Winther, 2014-09-29 13:01:23]

johnniwinther@google.com changed reviewers:
+ rnystrom@google.com

[Johnni Winther, 2014-09-29 13:01:24]

TBR

What is the intended procedure for generating pub and where is this described?

https://codereview.chromium.org/617433002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart (left):

https://codereview.chromium.org/617433002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart:363:
logFn(file.getLocationMessage(message, begin, end, true, (i) => i));
Edited by hand. Running sdk/bin/pub.bat didn't generate the code on Windows (it
worked for ricow on Linux).

[Johnni Winther, 2014-09-29 13:01:24]

TBR

What is the intended procedure for generating pub and where is this described?

https://codereview.chromium.org/617433002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart (left):

https://codereview.chromium.org/617433002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart:363:
logFn(file.getLocationMessage(message, begin, end, true, (i) => i));
Edited by hand. Running sdk/bin/pub.bat didn't generate the code on Windows (it
worked for ricow on Linux).

[Johnni Winther, 2014-09-29 13:02:55]

https://codereview.chromium.org/617433002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart (left):

https://codereview.chromium.org/617433002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart:363:
logFn(file.getLocationMessage(message, begin, end, true, (i) => i));
On 2014/09/29 13:01:24, Johnni Winther wrote:
> Edited by hand. Running sdk/bin/pub.bat didn't generate the code on Windows
(it
> worked for ricow on Linux).

Wrong source position. Disregard.

https://codereview.chromium.org/617433002/diff/1/sdk/lib/_internal/pub_genera...
File sdk/lib/_internal/pub_generated/lib/src/barback/dart2js_transformer.dart
(left):

https://codereview.chromium.org/617433002/diff/1/sdk/lib/_internal/pub_genera...
sdk/lib/_internal/pub_generated/lib/src/barback/dart2js_transformer.dart:235:
logFn(file.getLocationMessage(message, begin, end, true, (i) => i));
Edited by hand. Running sdk/bin/pub.bat didn't generate the code on Windows (it
worked for ricow on Linux).

[Johnni Winther, 2014-09-29 13:03:26]

Committed patchset #1 (id:1) manually as 40768 (presubmit successful).

[Bob Nystrom, 2014-09-29 15:49:13]

> What is the intended procedure for generating pub and where is this described?

Search for an email titled "Async/await, pub, and the repo".

https://codereview.chromium.org/617433002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart (left):

https://codereview.chromium.org/617433002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart:363:
logFn(file.getLocationMessage(message, begin, end, true, (i) => i));
I'm guessing this is to catch up to a change in dart2js? Unnamed boolean
parameters are usually a bad idea since they are hard to understand at the
callsite. See:
https://www.dartlang.org/articles/style-guide/#avoid-boolean-arguments-unless...

[Bob Nystrom, 2014-09-29 15:49:21]

lgtm

[Johnni Winther, 2014-09-30 07:20:43]

https://codereview.chromium.org/617433002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart (left):

https://codereview.chromium.org/617433002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart:363:
logFn(file.getLocationMessage(message, begin, end, true, (i) => i));
On 2014/09/29 15:49:13, Bob Nystrom wrote:
> I'm guessing this is to catch up to a change in dart2js? Unnamed boolean
> parameters are usually a bad idea since they are hard to understand at the
> callsite. See:
>
https://www.dartlang.org/articles/style-guide/#avoid-boolean-arguments-unless...

Yes. I made the change recently. I think method was pre-named-arguments.

After having made this change to dart2js_transformer.dart, how was I supposed to
generated the corresponding file in pub_generated?

[Johnni Winther, 2014-09-30 07:25:28]

On 2014/09/29 15:49:13, Bob Nystrom wrote:
> > What is the intended procedure for generating pub and where is this
described?
> 
> Search for an email titled "Async/await, pub, and the repo".
> 

This tells me to run the sdk/bin/pub bash script, but I am working on Windows,
and no, the pub.bat doesn't produce the pub_generated files.

[Johnni Winther, 2014-09-30 07:25:35]

https://codereview.chromium.org/617433002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart (left):

https://codereview.chromium.org/617433002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart:363:
logFn(file.getLocationMessage(message, begin, end, true, (i) => i));
On 2014/09/30 07:20:43, Johnni Winther wrote:
> On 2014/09/29 15:49:13, Bob Nystrom wrote:
> > I'm guessing this is to catch up to a change in dart2js? Unnamed boolean
> > parameters are usually a bad idea since they are hard to understand at the
> > callsite. See:
> >
>
https://www.dartlang.org/articles/style-guide/#avoid-boolean-arguments-unless...
> 
> Yes. I made the change recently. I think method was pre-named-arguments.
> 
> After having made this change to dart2js_transformer.dart, how was I supposed
to
> generated the corresponding file in pub_generated?

Disregard the last comment. I (as always) overlook general commments in review
tool....