Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 616983003: Disable 2 intrinsics causing optimizer issues (under investigation). (Closed)

Created:
6 years, 2 months ago by regis
Modified:
6 years, 2 months ago
Reviewers:
Cutch, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Disable 2 intrinsics causing optimizer issues (under investigation). Rename 2 intrinsics (was not the issue). Added a static cast to eliminate a warning on Windows. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=40825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -29 lines) Patch
M runtime/lib/bigint.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 3 chunks +12 lines, -8 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
regis
6 years, 2 months ago (2014-09-30 22:43:03 UTC) #2
Cutch
lgtm
6 years, 2 months ago (2014-09-30 22:55:31 UTC) #3
regis
6 years, 2 months ago (2014-09-30 23:01:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r40825 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698