Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 616673002: throw e is not a compile-time constant expression (Closed)

Created:
6 years, 2 months ago by hausner
Modified:
6 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

throw e is not a compile-time constant expression Detect illegal compile-time const expression and report error. Fixes 21146. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=40793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M runtime/vm/parser.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/language/compile_time_constant_r_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
6 years, 2 months ago (2014-09-29 22:28:27 UTC) #2
regis
LGTM
6 years, 2 months ago (2014-09-29 22:42:32 UTC) #3
hausner
6 years, 2 months ago (2014-09-29 22:47:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r40793 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698