Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 616593003: Fix crash during GC in gen_snapshot: (Closed)

Created:
6 years, 2 months ago by siva
Modified:
6 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix crash during GC in gen_snapshot: - There were some uninitialized fields in object_store which could contain some random initial values. These fields are part of the root set used during Garbage collection and if a Garbage collection was triggered before these fields are formally initialized in Object::init, it could lead to random behaviour. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=40794

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M runtime/vm/object_store.cc View 4 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
siva
6 years, 2 months ago (2014-09-29 22:35:11 UTC) #2
regis
LGTM!!
6 years, 2 months ago (2014-09-29 22:40:56 UTC) #3
siva
6 years, 2 months ago (2014-09-29 22:59:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r40794 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698