Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 616463004: pkg/shelf: include the original `onHijack` callback for Request.change (Closed)

Created:
6 years, 2 months ago by kevmoo
Modified:
6 years, 2 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/shelf: include the original `onHijack` callback for Request.change BUG= https://code.google.com/p/dart/issues/detail?id=21043 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=41102

Patch Set 1 #

Total comments: 6

Patch Set 2 : cl nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -7 lines) Patch
M pkg/shelf/CHANGELOG.md View 1 1 chunk +6 lines, -1 line 0 comments Download
M pkg/shelf/lib/src/request.dart View 1 2 chunks +21 lines, -5 lines 0 comments Download
M pkg/shelf/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/shelf/test/hijack_test.dart View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kevmoo
6 years, 2 months ago (2014-09-30 02:41:23 UTC) #2
kevmoo
On 2014/09/30 02:41:23, kevmoo wrote: ping?
6 years, 2 months ago (2014-10-08 10:34:59 UTC) #3
nweiz
lgtm https://codereview.chromium.org/616463004/diff/1/pkg/shelf/CHANGELOG.md File pkg/shelf/CHANGELOG.md (right): https://codereview.chromium.org/616463004/diff/1/pkg/shelf/CHANGELOG.md#newcode4 pkg/shelf/CHANGELOG.md:4: exists. Nit: +2 spaces. https://codereview.chromium.org/616463004/diff/1/pkg/shelf/lib/src/request.dart File pkg/shelf/lib/src/request.dart (right): ...
6 years, 2 months ago (2014-10-13 18:43:44 UTC) #4
kevmoo
https://codereview.chromium.org/616463004/diff/1/pkg/shelf/CHANGELOG.md File pkg/shelf/CHANGELOG.md (right): https://codereview.chromium.org/616463004/diff/1/pkg/shelf/CHANGELOG.md#newcode4 pkg/shelf/CHANGELOG.md:4: exists. On 2014/10/13 18:43:43, nweiz wrote: > Nit: +2 ...
6 years, 2 months ago (2014-10-14 16:42:38 UTC) #5
kevmoo
6 years, 2 months ago (2014-10-14 16:43:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:50001) manually as 41102 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698