Issue 61633003: Fix large-file support for mac os x.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 61633003: Fix large-file support for mac os x. (Closed)

Created:
7 years, 1 month ago by Anders Johnsen

Modified:
7 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix large-file support for mac os x. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=30404

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -43 lines)			Patch
M	runtime/bin/directory_macos.cc	View		5 chunks	+9 lines, -9 lines	0 comments	Download
M	runtime/bin/file_macos.cc	View		13 chunks	+29 lines, -29 lines	0 comments	Download
M	runtime/bin/socket_macos.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/platform/globals.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/platform/inttypes_support_win.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/61633003/diff/1/runtime/platform/globals.h File runtime/platform/globals.h (right): https://codereview.chromium.org/61633003/diff/1/runtime/platform/globals.h#newcode259 runtime/platform/globals.h:259: // off64_t is not defined on windows or ...

7 years, 1 month ago (2013-11-19 12:17:05 UTC) #2

Anders Johnsen

https://codereview.chromium.org/61633003/diff/1/runtime/platform/globals.h File runtime/platform/globals.h (right): https://codereview.chromium.org/61633003/diff/1/runtime/platform/globals.h#newcode259 runtime/platform/globals.h:259: // off64_t is not defined on windows or mac. ...

7 years, 1 month ago (2013-11-19 12:17:44 UTC) #3

Anders Johnsen

7 years, 1 month ago (2013-11-19 12:18:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r30404 (presubmit successful).

Expand Messages | Collapse Messages

Issue 61633003: Fix large-file support for mac os x. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages