Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 616103004: Second attempt at fixing warning on Windows. (Closed)

Created:
6 years, 2 months ago by regis
Modified:
6 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Second attempt at fixing warning on Windows. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=40827

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 4 (1 generated)
regis
6 years, 2 months ago (2014-09-30 23:46:42 UTC) #2
siva
lgtm https://codereview.chromium.org/616103004/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/616103004/diff/1/runtime/vm/object.cc#newcode16738 runtime/vm/object.cc:16738: return Neg() ? static_cast<uint32_t>(-static_cast<int32_t>(digit0)) : digit0; The multiple ...
6 years, 2 months ago (2014-10-01 00:04:40 UTC) #3
regis
6 years, 2 months ago (2014-10-01 00:20:47 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as r40827 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698