Fix circular ringbuffer used in socket implementation

Fix circular ringbuffer used in socket implementation

R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40811

[kustermann, 2014-09-30 11:23:17]

kustermann@google.com changed reviewers:
+ sgjesse@google.com

[kustermann, 2014-09-30 11:23:18]

I saw the following exception:

Uncaught error in request handler zone: RangeError: 107 must be in the range
[0..60)
Stack:
#0      _throwRangeError (dart:typed_data-patch/typed_data.dart:3638)
#1      _TypedListBase.setRange (dart:typed_data-patch/typed_data.dart:535)
#2      _ExternalBuffer.read (dart:io/secure_socket.dart:1135)
#3      _RawSecureSocket.read (dart:io/secure_socket.dart:697)
#4      Buffer.readFromSocket (package:sqljocky/src/buffer.dart:55:34)
#5      BufferedSocket._readBuffer
(package:sqljocky/src/buffered_socket.dart:174:50)
#6      BufferedSocket.readBuffer
(package:sqljocky/src/buffered_socket.dart:167:18)
#7      _handleHeader (package:sqljocky/src/connection.dart:144:25)
#8      _rootRunUnary (dart:async/zone.dart:730)
#9      _ZoneDelegate.runUnary (dart:async/zone.dart:462)
#10     _CustomizedZone.runUnary (dart:async/zone.dart:667)
#11     _Future._propagateToListeners.handleValueCallback
(dart:async/future_impl.dart:488)
#12     _Future._propagateToListeners (dart:async/future_impl.dart:571)
#13     _Future._completeWithValue (dart:async/future_impl.dart:331)
#14     _Future._asyncComplete.<anonymous closure>
(dart:async/future_impl.dart:393)
#15     _rootRun (dart:async/zone.dart:723)
#16     _ZoneDelegate.run (dart:async/zone.dart:453)
#17     _CustomizedZone.run (dart:async/zone.dart:663)
#18     _BaseZone.runGuarded (dart:async/zone.dart:574)
#19     _BaseZone.bindCallback.<anonymous closure> (dart:async/zone.dart:599)
#20     _asyncRunCallbackLoop (dart:async/schedule_microtask.dart:23)
#21     _asyncRunCallback (dart:async/schedule_microtask.dart:32)
#22     _RawReceivePortImpl._handleMessage
(dart:isolate-patch/isolate_patch.dart:128)


I think this CL should fix it.

I'm not that familiar with this code: Any ideas how we could write a regression
test for it?

[Søren Gjesse, 2014-09-30 11:33:53]

LGTM!

The question is whether it can be indirectly tested by using secure sockets
where the server is sending a large amount of data and the client (using a
RawSecureSocket) is just reading a few bytes at the time. Maybe checking
available to make sure the buffer is full.

[Søren Gjesse, 2014-09-30 11:43:24]

On 2014/09/30 11:33:53, Søren Gjesse wrote:
> LGTM!
> 
> The question is whether it can be indirectly tested by using secure sockets
> where the server is sending a large amount of data and the client (using a
> RawSecureSocket) is just reading a few bytes at the time. Maybe checking
> available to make sure the buffer is full.

And merge to trunk, and stable.

[kustermann, 2014-09-30 12:12:35]

PTAL: Added regression test which should trigger it.

[Søren Gjesse, 2014-09-30 12:15:58]

LGTM, thanks

[kustermann, 2014-09-30 13:19:45]

Committed patchset #3 (id:40001) manually as 40811 (presubmit successful).