Issue 615313004: Use simple prefix/suffix diff in members sorter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 615313004: Use simple prefix/suffix diff in members sorter. (Closed)

Created:
6 years, 2 months ago by scheglov

Modified:
6 years, 2 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use simple prefix/suffix diff in members sorter. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40880

Patch Set 1 #

Total comments: 2

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -2 lines)			Patch
A	pkg/analysis_server/lib/src/services/correction/diff.dart	View	1 chunk	+33 lines, -0 lines	2 comments	Download
M	pkg/analysis_server/lib/src/services/correction/sort_members.dart	View	2 chunks	+8 lines, -2 lines	0 comments	Download
A	pkg/analysis_server/test/services/correction/diff_test.dart	View	1 chunk	+31 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/correction/test_all.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/615313004/diff/1/pkg/analysis_server/lib/src/services/correction/diff.dart File pkg/analysis_server/lib/src/services/correction/diff.dart (right): https://codereview.chromium.org/615313004/diff/1/pkg/analysis_server/lib/src/services/correction/diff.dart#newcode1 pkg/analysis_server/lib/src/services/correction/diff.dart:1: library diff; missing copyright https://codereview.chromium.org/615313004/diff/1/pkg/analysis_server/lib/src/services/correction/diff.dart#newcode9 pkg/analysis_server/lib/src/services/correction/diff.dart:9: int findCommonPrefix(String ...

6 years, 2 months ago (2014-10-02 13:48:57 UTC) #2

scheglov

6 years, 2 months ago (2014-10-02 14:52:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40880 (presubmit successful).

Expand Messages | Collapse Messages