Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 614373003: Bump-pointer allocation when reading snapshot; 10-15% faster isolate creation. (Closed)

Created:
6 years, 2 months ago by koda
Modified:
6 years, 2 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Bump-pointer allocation when reading snapshot; 10-15% faster isolate creation. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=40888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/snapshot.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
koda
6 years, 2 months ago (2014-10-01 15:21:52 UTC) #1
koda
The increase in memory capacity footprint is never more than one heap page, and is ...
6 years, 2 months ago (2014-10-01 15:25:01 UTC) #2
koda
To clarify, this one-page overhead would already appear as soon as any promotion took place, ...
6 years, 2 months ago (2014-10-01 15:26:53 UTC) #3
Ivan Posva
LGTM -ip
6 years, 2 months ago (2014-10-02 19:52:42 UTC) #4
koda
6 years, 2 months ago (2014-10-02 20:45:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r40888 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698