Issue 61413002: Undo change 29900

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 61413002: Undo change 29900 (Closed)

Created:
7 years, 1 month ago by hausner

Modified:
7 years, 1 month ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Kevin Millikin (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Undo change 29900 Undo a gratuitous change to the parser. @kmillikin: please at least be courteous enough to ask one of the front-end authors to review a change that is not a pressing issue, such as style preferences. Committed: https://code.google.com/p/dart/source/detail?r=29954

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+161 lines, -156 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/parser.h	View	3 chunks	+13 lines, -28 lines	0 comments	Download
M	runtime/vm/parser.cc	View	14 chunks	+147 lines, -126 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

Committed patchset #1 manually as r29954 (presubmit successful).

7 years, 1 month ago (2013-11-06 01:21:38 UTC) #2

Message was sent while issue was closed.

LGTM -ip

Expand Messages | Collapse Messages