Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 613673006: Support more checked mode compile time errors in analysis engine. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Support more checked mode compile time errors in analysis engine. This changes the following errors to be checked mode compile time errors: - LIST_ELEMENT_TYPE_NOT_ASSIGNABLE - MAP_VALUE_TYPE_NOT_ASSIGNABLE - MAP_KEY_TYPE_NOT_ASSIGNABLE It also ensures that static warnings are always generated, so if the analysis engine's client decides to disregard checked mode compile time errors, the warnings won't be lost. BUG=dartbug.com/16391 R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40790

Patch Set 1 #

Messages

Total messages: 5 (1 generated)
Paul Berry
6 years, 2 months ago (2014-09-29 20:44:02 UTC) #2
Brian Wilkerson
LGTM
6 years, 2 months ago (2014-09-29 21:06:18 UTC) #3
scheglov
LGTM
6 years, 2 months ago (2014-09-29 21:11:31 UTC) #4
Paul Berry
6 years, 2 months ago (2014-09-29 21:42:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40790 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698