Issue 61263003: DOCSONLY Update CanvasImageSource docs to better reflect proper style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 61263003: DOCSONLY Update CanvasImageSource docs to better reflect proper style. (Closed)

Created:
7 years, 1 month ago by Andrei Mouravski

Modified:
7 years, 1 month ago

Reviewers:
Kathy Walrath

CC:
reviews_dartlang.org, blois

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update CanvasImageSource docs to better reflect proper style. Committed: https://code.google.com/p/dart/source/detail?r=29948

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -57 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		1 chunk	+30 lines, -19 lines	2 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+30 lines, -19 lines	0 comments	Download
M	tools/dom/src/CanvasImageSource.dart	View	1	1 chunk	+30 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Andrei Mouravski

This CL is mostly me going through the style guides and updating as seems appropriate.

7 years, 1 month ago (2013-11-06 00:22:29 UTC) #1

Andrei Mouravski

On 2013/11/06 00:22:29, Andrei Mouravski wrote: > This CL is mostly me going through the ...

7 years, 1 month ago (2013-11-06 00:24:19 UTC) #2

Andrei Mouravski

Committed patchset #2 manually as r29948 (presubmit successful).

7 years, 1 month ago (2013-11-06 00:24:54 UTC) #3

Kathy Walrath

7 years, 1 month ago (2013-11-06 18:09:05 UTC) #4

Message was sent while issue was closed.

lgtm, but I couldn't help making some suggestions for improvement.

https://codereview.chromium.org/61263003/diff/40001/sdk/lib/html/dart2js/html...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/61263003/diff/40001/sdk/lib/html/dart2js/html...
sdk/lib/html/dart2js/html_dart2js.dart:29762: + * This object is either an
[ImageElement], [VideoElement], or
How about deleting this paragraph entirely. It's implied by the following list.

(also, it raised a bunch of questions that aren't necessary, and "either" with
>2 objects is a little unusual)

https://codereview.chromium.org/61263003/diff/40001/sdk/lib/html/dart2js/html...
sdk/lib/html/dart2js/html_dart2js.dart:29765: + * The image drawn to the canvas
differs by implementation:
"differs by implementation" is vague. How about:

The image drawn to the canvas depends on the type of this object:

Expand Messages | Collapse Messages