Issue 612213002: Clear the handle returned by HashTable::Release in ~HashTable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 612213002: Clear the handle returned by HashTable::Release in ~HashTable. (Closed)

Created:
6 years, 2 months ago by koda

Modified:
6 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Clear the handle returned by HashTable::Release in ~HashTable. This is a fix to the issue of EnsureCapacity retaining old arrays until the end of the current handle scope. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=40817

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -7 lines)			Patch
	M	runtime/vm/hash_table.h	View		3 chunks	+16 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

koda

I'm considering renaming 'Release', or splitting it into two cases, depending on whether the caller ...

6 years, 2 months ago (2014-09-29 22:08:53 UTC) #2

koda

6 years, 2 months ago (2014-09-30 17:05:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r40817 (presubmit successful).