Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 612053002: Api roll 2: 2014-09-29 (Closed)

Created:
6 years, 2 months ago by Søren Gjesse
Modified:
6 years, 2 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/googleapis.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Push CHANGELOG-md changes to generated package #

Patch Set 3 : Updated comment in config.yaml #

Total comments: 18

Patch Set 4 : Addressed review comments #

Patch Set 5 : Forgot to add test for generated/googleapis_beta/test/resourceviews/v1beta1_test.dart #

Total comments: 2

Patch Set 6 : Addressed more review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12094 lines, -8020 lines) Patch
M .gitignore View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M config.yaml View 1 2 3 4 5 5 chunks +7 lines, -3 lines 0 comments Download
M discovery/googleapis/adexchangebuyer__v1.3.json View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M discovery/googleapis/adexchangeseller__v1.1.json View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
A + discovery/googleapis/adexchangeseller__v2.0.json View 1 2 3 4 5 14 chunks +410 lines, -487 lines 0 comments Download
M discovery/googleapis/adsense__v1.4.json View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M discovery/googleapis/adsensehost__v4.1.json View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M discovery/googleapis/appstate__v1.json View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M discovery/googleapis/calendar__v3.json View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M discovery/googleapis/civicinfo__us_v1.json View 1 2 3 4 5 3 chunks +5 lines, -2 lines 0 comments Download
M discovery/googleapis/civicinfo__v1.json View 1 2 3 4 5 3 chunks +5 lines, -2 lines 0 comments Download
A + discovery/googleapis/civicinfo__v2.json View 1 2 3 4 5 15 chunks +241 lines, -82 lines 0 comments Download
M discovery/googleapis/drive__v2.json View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M discovery/googleapis/gamesManagement__v1management.json View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M discovery/googleapis/games__v1.json View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M discovery/googleapis/mapsengine__v1.json View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M discovery/googleapis/plusDomains__v1.json View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M discovery/googleapis/plus__v1.json View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
A discovery/googleapis/webmasters__v3.json View 1 2 3 4 5 1 chunk +806 lines, -0 lines 0 comments Download
M discovery/googleapis/youtube__v3.json View 1 2 3 4 5 5 chunks +28 lines, -4 lines 0 comments Download
M discovery/googleapis_beta/dns__v1beta1.json View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M discovery/googleapis_beta/genomics__v1beta.json View 1 2 3 4 5 12 chunks +60 lines, -8 lines 0 comments Download
A + discovery/googleapis_beta/resourceviews__v1beta2.json View 1 2 3 4 5 24 chunks +485 lines, -352 lines 0 comments Download
M generated/googleapis/CHANGELOG.md View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download
M generated/googleapis/README.md View 1 2 3 4 5 3 chunks +19 lines, -1 line 0 comments Download
A + generated/googleapis/lib/adexchangeseller/v2_0.dart View 1 2 3 4 5 62 chunks +170 lines, -397 lines 0 comments Download
M generated/googleapis/lib/civicinfo/us_v1.dart View 1 2 3 4 5 3 chunks +9 lines, -0 lines 0 comments Download
M generated/googleapis/lib/civicinfo/v1.dart View 1 2 3 4 5 3 chunks +9 lines, -0 lines 0 comments Download
A + generated/googleapis/lib/civicinfo/v2.dart View 1 2 3 4 5 31 chunks +206 lines, -149 lines 0 comments Download
M generated/googleapis/lib/src/common_internal.dart View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A generated/googleapis/lib/webmasters/v3.dart View 1 2 3 4 5 1 chunk +1160 lines, -0 lines 0 comments Download
M generated/googleapis/lib/youtube/v3.dart View 1 2 3 4 5 9 chunks +56 lines, -0 lines 0 comments Download
M generated/googleapis/pubspec.yaml View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M generated/googleapis/test/adexchangebuyer/v1_3_test.dart View 1 2 3 4 5 37 chunks +174 lines, -174 lines 0 comments Download
M generated/googleapis/test/adexchangeseller/v1_1_test.dart View 1 2 3 4 5 29 chunks +90 lines, -90 lines 0 comments Download
A + generated/googleapis/test/adexchangeseller/v2_0_test.dart View 1 2 3 4 5 69 chunks +301 lines, -452 lines 0 comments Download
M generated/googleapis/test/admin/directory_v1_test.dart View 1 2 3 4 5 62 chunks +112 lines, -112 lines 0 comments Download
M generated/googleapis/test/admin/email_migration_v2_test.dart View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M generated/googleapis/test/admin/reports_v1_test.dart View 1 2 3 4 5 23 chunks +50 lines, -50 lines 0 comments Download
M generated/googleapis/test/adsense/v1_4_test.dart View 1 2 3 4 5 38 chunks +117 lines, -117 lines 0 comments Download
M generated/googleapis/test/adsensehost/v4_1_test.dart View 1 2 3 4 5 25 chunks +83 lines, -83 lines 0 comments Download
M generated/googleapis/test/analytics/v3_test.dart View 1 2 3 4 5 121 chunks +230 lines, -230 lines 0 comments Download
M generated/googleapis/test/androidpublisher/v2_test.dart View 1 2 3 4 5 33 chunks +56 lines, -56 lines 0 comments Download
M generated/googleapis/test/appsactivity/v1_test.dart View 1 2 3 4 5 13 chunks +32 lines, -32 lines 0 comments Download
M generated/googleapis/test/appstate/v1_test.dart View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M generated/googleapis/test/bigquery/v2_test.dart View 1 2 3 4 5 53 chunks +79 lines, -79 lines 0 comments Download
M generated/googleapis/test/blogger/v3_test.dart View 1 2 3 4 5 34 chunks +65 lines, -65 lines 0 comments Download
M generated/googleapis/test/books/v1_test.dart View 1 2 3 4 5 69 chunks +147 lines, -147 lines 0 comments Download
M generated/googleapis/test/calendar/v3_test.dart View 1 2 3 4 5 49 chunks +104 lines, -104 lines 0 comments Download
M generated/googleapis/test/civicinfo/us_v1_test.dart View 1 2 3 4 5 34 chunks +106 lines, -104 lines 0 comments Download
M generated/googleapis/test/civicinfo/v1_test.dart View 1 2 3 4 5 34 chunks +106 lines, -104 lines 0 comments Download
A + generated/googleapis/test/civicinfo/v2_test.dart View 1 2 3 4 5 44 chunks +386 lines, -209 lines 0 comments Download
M generated/googleapis/test/compute/v1_test.dart View 1 2 3 4 5 222 chunks +372 lines, -372 lines 0 comments Download
M generated/googleapis/test/content/v2_test.dart View 1 2 3 4 5 88 chunks +168 lines, -168 lines 0 comments Download
M generated/googleapis/test/coordinate/v1_test.dart View 1 2 3 4 5 23 chunks +41 lines, -41 lines 0 comments Download
M generated/googleapis/test/customsearch/v1_test.dart View 1 2 3 4 5 11 chunks +52 lines, -52 lines 0 comments Download
M generated/googleapis/test/dfareporting/v1_3_test.dart View 1 2 3 4 5 48 chunks +216 lines, -216 lines 0 comments Download
M generated/googleapis/test/discovery/v1_test.dart View 1 2 3 4 5 31 chunks +80 lines, -80 lines 0 comments Download
M generated/googleapis/test/doubleclickbidmanager/v1_test.dart View 1 2 3 4 5 19 chunks +40 lines, -40 lines 0 comments Download
M generated/googleapis/test/doubleclicksearch/v2_test.dart View 1 2 3 4 5 22 chunks +48 lines, -48 lines 0 comments Download
M generated/googleapis/test/drive/v2_test.dart View 1 2 3 4 5 65 chunks +148 lines, -148 lines 0 comments Download
M generated/googleapis/test/freebase/v1_test.dart View 1 2 3 4 5 7 chunks +38 lines, -38 lines 0 comments Download
M generated/googleapis/test/fusiontables/v1_test.dart View 1 2 3 4 5 41 chunks +88 lines, -88 lines 0 comments Download
M generated/googleapis/test/games/v1_test.dart View 1 2 3 4 5 108 chunks +180 lines, -180 lines 0 comments Download
M generated/googleapis/test/gamesmanagement/v1management_test.dart View 1 2 3 4 5 9 chunks +12 lines, -12 lines 0 comments Download
M generated/googleapis/test/gmail/v1_test.dart View 1 2 3 4 5 29 chunks +65 lines, -65 lines 0 comments Download
M generated/googleapis/test/identitytoolkit/v3_test.dart View 1 2 3 4 5 24 chunks +40 lines, -40 lines 0 comments Download
M generated/googleapis/test/licensing/v1_test.dart View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M generated/googleapis/test/mapsengine/v1_test.dart View 1 2 3 4 5 117 chunks +219 lines, -219 lines 0 comments Download
M generated/googleapis/test/mirror/v1_test.dart View 1 2 3 4 5 33 chunks +72 lines, -72 lines 0 comments Download
M generated/googleapis/test/orkut/v2_test.dart View 1 2 3 4 5 58 chunks +108 lines, -108 lines 0 comments Download
M generated/googleapis/test/pagespeedonline/v1_test.dart View 1 2 3 4 5 21 chunks +35 lines, -35 lines 0 comments Download
M generated/googleapis/test/plus/v1_test.dart View 1 2 3 4 5 36 chunks +72 lines, -72 lines 0 comments Download
M generated/googleapis/test/plusdomains/v1_test.dart View 1 2 3 4 5 41 chunks +72 lines, -72 lines 0 comments Download
M generated/googleapis/test/prediction/v1_6_test.dart View 1 2 3 4 5 29 chunks +70 lines, -70 lines 0 comments Download
M generated/googleapis/test/qpxexpress/v1_test.dart View 1 2 3 4 5 29 chunks +76 lines, -76 lines 0 comments Download
M generated/googleapis/test/reseller/v1_test.dart View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M generated/googleapis/test/siteverification/v1_test.dart View 1 2 3 4 5 5 chunks +8 lines, -8 lines 0 comments Download
M generated/googleapis/test/storage/v1_test.dart View 1 2 3 4 5 27 chunks +64 lines, -64 lines 0 comments Download
M generated/googleapis/test/tasks/v1_test.dart View 1 2 3 4 5 8 chunks +12 lines, -12 lines 0 comments Download
M generated/googleapis/test/translate/v2_test.dart View 1 2 3 4 5 12 chunks +21 lines, -21 lines 0 comments Download
M generated/googleapis/test/urlshortener/v1_test.dart View 1 2 3 4 5 6 chunks +20 lines, -20 lines 0 comments Download
M generated/googleapis/test/webfonts/v1_test.dart View 1 2 3 4 5 5 chunks +16 lines, -16 lines 0 comments Download
A generated/googleapis/test/webmasters/v3_test.dart View 1 2 3 4 5 1 chunk +1134 lines, -0 lines 0 comments Download
M generated/googleapis/test/youtube/v3_test.dart View 1 2 3 4 5 100 chunks +178 lines, -172 lines 0 comments Download
M generated/googleapis/test/youtubeanalytics/v1_test.dart View 1 2 3 4 5 15 chunks +30 lines, -30 lines 0 comments Download
M generated/googleapis_beta/CHANGELOG.md View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M generated/googleapis_beta/README.md View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M generated/googleapis_beta/lib/genomics/v1beta.dart View 1 2 3 4 5 16 chunks +130 lines, -11 lines 0 comments Download
A + generated/googleapis_beta/lib/resourceviews/v1beta2.dart View 1 2 3 4 5 33 chunks +815 lines, -467 lines 0 comments Download
M generated/googleapis_beta/lib/src/common_internal.dart View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M generated/googleapis_beta/pubspec.yaml View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M generated/googleapis_beta/test/autoscaler/v1beta2_test.dart View 1 2 3 4 5 15 chunks +24 lines, -24 lines 0 comments Download
M generated/googleapis_beta/test/cloudmonitoring/v2beta1_test.dart View 1 2 3 4 5 21 chunks +34 lines, -34 lines 0 comments Download
M generated/googleapis_beta/test/datastore/v1beta2_test.dart View 1 2 3 4 5 36 chunks +96 lines, -96 lines 0 comments Download
M generated/googleapis_beta/test/dns/v1beta1_test.dart View 1 2 3 4 5 15 chunks +28 lines, -28 lines 0 comments Download
M generated/googleapis_beta/test/genomics/v1beta_test.dart View 1 2 3 4 5 74 chunks +296 lines, -214 lines 0 comments Download
M generated/googleapis_beta/test/manager/v1beta2_test.dart View 1 2 3 4 5 36 chunks +96 lines, -96 lines 0 comments Download
M generated/googleapis_beta/test/pubsub/v1beta1_test.dart View 1 2 3 4 5 11 chunks +16 lines, -16 lines 0 comments Download
M generated/googleapis_beta/test/replicapool/v1beta1_test.dart View 1 2 3 4 5 27 chunks +72 lines, -72 lines 0 comments Download
M generated/googleapis_beta/test/resourceviews/v1beta1_test.dart View 1 2 3 4 5 22 chunks +40 lines, -40 lines 0 comments Download
A + generated/googleapis_beta/test/resourceviews/v1beta2_test.dart View 1 2 3 4 5 25 chunks +555 lines, -423 lines 0 comments Download
M generated/googleapis_beta/test/sqladmin/v1beta3_test.dart View 1 2 3 4 5 37 chunks +76 lines, -76 lines 0 comments Download
M generated/googleapis_beta/test/taskqueue/v1beta2_test.dart View 1 2 3 4 5 8 chunks +20 lines, -20 lines 0 comments Download
M pubspec.lock View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M resources/googleapis/CHANGELOG.md View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M resources/googleapis_beta/CHANGELOG.md View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Søren Gjesse
As far as I can see all changes are non-breaking (adding fields to schema's and ...
6 years, 2 months ago (2014-09-29 11:49:35 UTC) #1
kustermann
https://codereview.chromium.org/612053002/diff/20001/config.yaml File config.yaml (right): https://codereview.chromium.org/612053002/diff/20001/config.yaml#newcode3 config.yaml:3: version: 0.2.0 Increment to 0.2.1 https://codereview.chromium.org/612053002/diff/20001/config.yaml#newcode68 config.yaml:68: version: 0.2.0 ...
6 years, 2 months ago (2014-09-29 12:04:32 UTC) #2
Søren Gjesse
Kept API resourceviews:v1beta1 in googleapis_beta. https://codereview.chromium.org/612053002/diff/20001/config.yaml File config.yaml (right): https://codereview.chromium.org/612053002/diff/20001/config.yaml#newcode3 config.yaml:3: version: 0.2.0 On 2014/09/29 ...
6 years, 2 months ago (2014-09-29 12:27:16 UTC) #3
kustermann
lgtm with small comment https://codereview.chromium.org/612053002/diff/40001/config.yaml File config.yaml (right): https://codereview.chromium.org/612053002/diff/40001/config.yaml#newcode115 config.yaml:115: - resourceviews:v1beta1 # v1beta2 included ...
6 years, 2 months ago (2014-09-29 13:05:30 UTC) #4
Søren Gjesse
https://codereview.chromium.org/612053002/diff/40001/config.yaml File config.yaml (right): https://codereview.chromium.org/612053002/diff/40001/config.yaml#newcode115 config.yaml:115: - resourceviews:v1beta1 # v1beta2 included On 2014/09/29 13:05:30, kustermann ...
6 years, 2 months ago (2014-09-29 14:16:32 UTC) #5
Søren Gjesse
6 years, 2 months ago (2014-09-29 15:57:03 UTC) #6
Message was sent while issue was closed. 
Committed patchset #6 (id:50001) manually as a7d1bd0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698