Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 61193002: Add a build filter (only necessary HTML files are emitted) and logic to use .min.js (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)
Modified:
7 years, 1 month ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a build filter (only necessary HTML files are emitted) and logic to use .min.js by default, but keeps it disabled until the dart2js/mirrors bugs are addressed (dartbug.com/14720). R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=30164

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -22 lines) Patch
M pkg/polymer/lib/builder.dart View 4 chunks +16 lines, -3 lines 0 comments Download
M pkg/polymer/lib/deploy.dart View 4 chunks +12 lines, -4 lines 0 comments Download
A pkg/polymer/lib/src/build/build_filter.dart View 1 1 chunk +44 lines, -0 lines 0 comments Download
M pkg/polymer/lib/src/build/common.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/polymer/lib/src/build/polyfill_injector.dart View 1 2 2 chunks +8 lines, -7 lines 0 comments Download
M pkg/polymer/lib/transformer.dart View 1 2 3 3 chunks +10 lines, -6 lines 0 comments Download
M pkg/polymer/test/build/common.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-11-05 23:08:14 UTC) #1
Jennifer Messerly
lgtm
7 years, 1 month ago (2013-11-06 02:40:31 UTC) #2
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-11-11 18:39:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r30164 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698