Fix a bug in the type inferrer.

Fix a bug in the type inferrer.

The optimization for non-final fields initialized in a generative constructor did not take into account whether the super constructor call escapes 'this', or uses an un-initialized field.

The fix is to ensure we analyze the super constructor first before analyzing a constructor.

R=lry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30408

[lukas, 2013-11-19 11:49:56]

lgtm

https://codereview.chromium.org/61163005/diff/30001/sdk/lib/_internal/compile...
File
sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/61163005/diff/30001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart:612:
return (element.getEnclosingClass() == cls)
element.getEnclosingClass() -> enclosing

[ngeoffray, 2013-11-19 12:49:38]

Thanks Lukas.

https://codereview.chromium.org/61163005/diff/30001/sdk/lib/_internal/compile...
File
sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/61163005/diff/30001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart:612:
return (element.getEnclosingClass() == cls)
On 2013/11/19 11:49:56, lukas wrote:
> element.getEnclosingClass() -> enclosing

Done.

[ngeoffray, 2013-11-19 12:57:03]

Committed patchset #2 manually as r30408 (presubmit successful).