Issue 61153006: Add closure object type to debugger wire protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 61153006: Add closure object type to debugger wire protocol (Closed)

Created:
7 years, 1 month ago by hausner

Modified:
7 years, 1 month ago

Reviewers:
devoncarew

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -13 lines)			Patch
M	runtime/bin/dbg_message.cc	View	1	1 chunk	+28 lines, -10 lines	0 comments	Download
M	runtime/include/dart_debugger_api.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger_api_impl_test.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	tools/ddbg.dart	View	1	2 chunks	+9 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

hausner

Devon, does this update to the wire protocol work for you? Let me know whether ...

7 years, 1 month ago (2013-11-12 22:11:15 UTC) #1

devoncarew

lgtm The changes look good. I have a corresponding CL on the editor side. There ...

7 years, 1 month ago (2013-11-12 23:20:16 UTC) #2

hausner

7 years, 1 month ago (2013-11-14 19:42:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r30289 (presubmit successful).