Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 610913003: Triaged co19 dart2js Language tests until line 436 (Closed)

Created:
6 years, 2 months ago by eernst
Modified:
6 years, 2 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Triaged co19 dart2js Language tests until line 436 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=40771

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Removed spurious TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M tests/co19/co19-dart2js.status View 1 2 3 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
eernst
6 years, 2 months ago (2014-09-29 15:37:04 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/610913003/diff/20001/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/610913003/diff/20001/tests/co19/co19-dart2js.status#newcode436 tests/co19/co19-dart2js.status:436: Language/12_Expressions/30_Identifier_Reference_A02_t01: fail # co19-roll r546: Please triage this ...
6 years, 2 months ago (2014-09-29 15:37:47 UTC) #3
eernst
https://codereview.chromium.org/610913003/diff/20001/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/610913003/diff/20001/tests/co19/co19-dart2js.status#newcode436 tests/co19/co19-dart2js.status:436: Language/12_Expressions/30_Identifier_Reference_A02_t01: fail # co19-roll r546: Please triage this failure ...
6 years, 2 months ago (2014-09-29 15:41:47 UTC) #4
eernst
6 years, 2 months ago (2014-09-29 15:44:18 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 40771 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698